Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore compatibility of GSF with gcc-8 #1600

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

benjaminhuth
Copy link
Member

Adds preprocessor guards around a statement GCC 8 seems not be able to compile (though it is valid C++).

@benjaminhuth benjaminhuth added this to the next milestone Oct 17, 2022
@benjaminhuth benjaminhuth added Bug Something isn't working Component - Core Affects the Core module labels Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #1600 (1ff4409) into main (b18804a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1600   +/-   ##
=======================================
  Coverage   48.54%   48.54%           
=======================================
  Files         381      381           
  Lines       20785    20785           
  Branches     9536     9536           
=======================================
  Hits        10090    10090           
  Misses       4112     4112           
  Partials     6583     6583           
Impacted Files Coverage Δ
...Acts/Utilities/detail/gaussian_mixture_helpers.hpp 69.64% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 0273fb8 into acts-project:main Oct 18, 2022
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Oct 20, 2022
Adds preprocessor guards around a statement GCC 8 seems not be able to compile (though it is valid C++).
paulgessinger pushed a commit that referenced this pull request Oct 20, 2022
Adds preprocessor guards around a statement GCC 8 seems not be able to compile (though it is valid C++).
@paulgessinger paulgessinger modified the milestones: next, v21.0.0 Nov 3, 2022
@benjaminhuth benjaminhuth deleted the fix/gsf-gcc-8-patch branch November 9, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported to develop/v19.x ✅ Bug Something isn't working Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants