refactor!: Put GSF in namespace Acts::Experimental #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
added
Component - Core
benjaminhuth
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1609 +/- ##
==========================================
- Coverage 48.66% 48.63% -0.03%
==========================================
Files 381 381
Lines 20776 20786 +10
Branches 9517 9519 +2
==========================================
Hits 10110 10110
- Misses 4095 4105 +10
Partials 6571 6571
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
looks good to me. not sure if anybody else wants to take a look as this is a breaking change. cc @asalzburger @paulgessinger
|
Maybe we should also quickly discuss this in tomorrows developer meeting, since it proposes changes to the definition of the public API / the versioning... |
andiwand
approved these changes
Oct 26, 2022
📊 Physics performance monitoring for d18177aFull report VertexingIVF seededIVF truth smearedIVF truth estimatedCKFseededtruth smearedtruth estimatedAmbiguity resolutionseededTruth trackingTruth tracking |
asalzburger
approved these changes
Oct 26, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
This PR refactors a bit the Bethe Heitler Approximation * moving it out of namespace `detail`, since its in fact part of the API of the GSF * allow loading parameterizations from the python examples Already contains #1609
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
This is a major refactoring of the GSF. It changes the propagation structure, and the way the GSF records states to the `MultiTrajectory`. It also removes the smoothing code, since it is not really useful at the moment, as the component states are not exported anyways. should be merged after #1609 and #1627 and #1628 We should add performance monitoring in this or a later PR Fixes #1666
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
This is a major refactoring of the GSF. It changes the propagation structure, and the way the GSF records states to the `MultiTrajectory`. It also removes the smoothing code, since it is not really useful at the moment, as the component states are not exported anyways. should be merged after acts-project#1609 and acts-project#1627 and acts-project#1628 We should add performance monitoring in this or a later PR Fixes acts-project#1666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the GSF is not yet fully functional, it is put in the namespace
Acts::Experimental.Also adds some hints in the documentation, that components in this namespace are not yet production read, and also not part of the public API (I think that is reasonable, since clients should not rely on experimental code).
However, since this would be a new rule, this change is breaking.