Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seed confirmation in orthogonal seed finder #1611

Merged
merged 11 commits into from
Nov 1, 2022

Conversation

LuisFelipeCoelho
Copy link
Member

@LuisFelipeCoelho LuisFelipeCoelho commented Oct 21, 2022

This is the same as in the default seeding

@LuisFelipeCoelho LuisFelipeCoelho added Improvement Changes to an existing feature 🚧 WIP Work-in-progress Component - Core Affects the Core module Component - Examples Affects the Examples module labels Oct 21, 2022
@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Oct 21, 2022
@LuisFelipeCoelho LuisFelipeCoelho marked this pull request as ready for review October 25, 2022 14:31
@LuisFelipeCoelho LuisFelipeCoelho removed the 🚧 WIP Work-in-progress label Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #1611 (07ef045) into main (75f9338) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1611   +/-   ##
=======================================
  Coverage   48.58%   48.58%           
=======================================
  Files         381      381           
  Lines       20833    20833           
  Branches     9557     9557           
=======================================
  Hits        10122    10122           
  Misses       4108     4108           
  Partials     6603     6603           
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SeedFinderConfig.hpp 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 25, 2022

📊 Physics performance monitoring for 07ef045

Full report
CKF: seeded, truth smeared, truth estimated
IVF: seeded, truth smeared, truth estimated
Ambiguity resolution
Truth tracking

Vertexing

IVF seeded

IVF truth smeared

IVF truth estimated

CKF

seeded

truth smeared

truth estimated

Ambiguity resolution

seeded

Truth tracking

Truth tracking

Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 65ea889 into acts-project:main Nov 1, 2022
@github-actions github-actions bot removed the automerge label Nov 1, 2022
@paulgessinger paulgessinger modified the milestones: next, v21.0.0 Nov 3, 2022
@LuisFelipeCoelho LuisFelipeCoelho deleted the orthognoal-seedConf branch January 16, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants