Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: DD4hep detector access #1637

Merged
merged 9 commits into from
Nov 1, 2022
Merged

refactor: DD4hep detector access #1637

merged 9 commits into from
Nov 1, 2022

Conversation

andiwand
Copy link
Contributor

noticed that we pass around the geometry service in python which seems confusing and can be solved more directly by exposing the dd4hep::Detector object

@andiwand andiwand added Impact - Minor Nuissance bug and/or affects only a single module Component - Examples Affects the Examples module labels Oct 31, 2022
@andiwand andiwand added this to the next milestone Oct 31, 2022
@andiwand andiwand force-pushed the refactor-examples-dd4hep-internals branch from bafeeb1 to 0fc77b9 Compare October 31, 2022 12:01
paulgessinger
paulgessinger approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

github-actions bot commented Oct 31, 2022 •
edited

📊 Physics performance monitoring for 36cd82a

Full report
CKF: seeded, truth smeared, truth estimated
IVF: seeded, truth smeared, truth estimated
Ambiguity resolution
Truth tracking

Vertexing

IVF seeded

IVF truth smeared

IVF truth estimated

CKF

seeded

truth smeared

truth estimated

Ambiguity resolution

seeded

Truth tracking

Truth tracking

@codecov
Copy link

codecov bot commented Oct 31, 2022 •
edited

Codecov Report

Merging #1637 (36cd82a) into main (c780eb2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1637   +/-   ##
=======================================
  Coverage   48.58%   48.58%           
=======================================
  Files         381      381           
  Lines       20833    20833           
  Branches     9557     9557           
=======================================
  Hits        10122    10122           
  Misses       4108     4108           
  Partials     6603     6603

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

benjaminhuth
benjaminhuth approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, improves the interface quite a bit. Just a minor comment, feel free to ignore it!

Examples/Python/python/acts/examples/simulation.py Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 75f9338 into acts-project:main Nov 1, 2022
@github-actions github-actions bot removed the automerge label Nov 1, 2022
@paulgessinger paulgessinger modified the milestones: next, v21.0.0 Nov 3, 2022
@andiwand andiwand deleted the refactor-examples-dd4hep-internals branch January 24, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminhuth benjaminhuth benjaminhuth approved these changes

@paulgessinger paulgessinger Awaiting requested review from paulgessinger

Assignees
No one assigned
Labels
Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andiwand @paulgessinger @benjaminhuth