Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ITk full chain #1642

Merged
merged 3 commits into from
Nov 1, 2022
Merged

fix: ITk full chain #1642

merged 3 commits into from
Nov 1, 2022

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Nov 1, 2022 •
edited

@andiwand andiwand added the Component - Examples Affects the Examples module label Nov 1, 2022
@andiwand andiwand added this to the next milestone Nov 1, 2022
@andiwand andiwand requested a review from timadye November 1, 2022 12:11
@codecov
Copy link

codecov bot commented Nov 1, 2022 •
edited

Codecov Report

Merging #1642 (e4f5867) into main (ec15a62) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1642   +/-   ##
=======================================
  Coverage   48.58%   48.58%           
=======================================
  Files         381      381           
  Lines       20833    20833           
  Branches     9557     9557           
=======================================
  Hits        10122    10122           
  Misses       4108     4108           
  Partials     6603     6603

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

timadye
timadye approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@timadye timadye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I tested this with ttbar_pu200=False and True and it seems to work nicely.
I see there's now a performance_ambi.root (just running CKFPerformanceWriter again). Nice!

@andiwand
Copy link
Contributor Author

andiwand commented Nov 1, 2022

I see there's now a performance_ambi.root (just running CKFPerformanceWriter again). Nice!

yes @paulgessinger suggested to have an output to monitor this. I thought it might be easiest to reuse the CKFPerformanceWriter as it operates on the same data 😄

@github-actions
Copy link

github-actions bot commented Nov 1, 2022 •
edited

📊 Physics performance monitoring for e4f5867

Full report
CKF: seeded, truth smeared, truth estimated
IVF: seeded, truth smeared, truth estimated
Ambiguity resolution
Truth tracking

Vertexing

IVF seeded

IVF truth smeared

IVF truth estimated

CKF

seeded

truth smeared

truth estimated

Ambiguity resolution

seeded

Truth tracking

Truth tracking

@andiwand andiwand requested a review from timadye November 1, 2022 13:49
timadye
timadye approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@timadye timadye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit c780eb2 into acts-project:main Nov 1, 2022
@github-actions github-actions bot removed the automerge label Nov 1, 2022
@goetzgaycken goetzgaycken mentioned this pull request Nov 2, 2022
Closed
@paulgessinger paulgessinger modified the milestones: next, v21.0.0 Nov 3, 2022
@andiwand andiwand deleted the fix-itk-full-chain branch January 24, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timadye timadye timadye approved these changes

Assignees

@timadye timadye

Labels
Component - Examples Affects the Examples module
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.

Error in running the ATLAS ITk example
3 participants
@andiwand @timadye @paulgessinger