Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Improve physmon report comment #1648

Merged
merged 6 commits into from
Nov 7, 2022

Conversation

paulgessinger
Copy link
Member

With these changes, if the physmon job didn't complete successfully, the report comment will look something like this:

image

@paulgessinger paulgessinger added this to the next milestone Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

📊 Physics performance monitoring for 8a55d6a

Full report
CKF: seeded, truth smeared, truth estimated
IVF: seeded, truth smeared, truth estimated
Ambiguity resolution
Truth tracking

Vertexing

IVF seeded

IVF truth smeared

IVF truth estimated

CKF

seeded

truth smeared

truth estimated

Ambiguity resolution

seeded

Truth tracking

Truth tracking

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! just a few very minor comments, feel free to ignore them

CI/physmon/generate_comment.py Outdated Show resolved Hide resolved
CI/physmon/generate_comment.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #1648 (8a55d6a) into main (95b99b0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1648   +/-   ##
=======================================
  Coverage   48.49%   48.49%           
=======================================
  Files         384      384           
  Lines       21059    21059           
  Branches     9694     9694           
=======================================
  Hits        10213    10213           
  Misses       4122     4122           
  Partials     6724     6724           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 472459a into acts-project:main Nov 7, 2022
@github-actions github-actions bot removed the automerge label Nov 7, 2022
@paulgessinger paulgessinger modified the milestones: next, v21.1.0 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants