Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Floating point exception monitoring #1649

Merged
merged 47 commits into from
Dec 19, 2022

Conversation

paulgessinger
Copy link
Member

No description provided.

@paulgessinger paulgessinger added the 🚧 WIP Work-in-progress label Nov 3, 2022
@paulgessinger paulgessinger added this to the next milestone Nov 3, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1649 (14e4a0b) into main (7a4286a) will increase coverage by 0.02%.
The diff coverage is 63.04%.

@@            Coverage Diff             @@
##             main    #1649      +/-   ##
==========================================
+ Coverage   49.14%   49.16%   +0.02%     
==========================================
  Files         395      396       +1     
  Lines       21800    21840      +40     
  Branches     9953     9968      +15     
==========================================
+ Hits        10713    10738      +25     
- Misses       4187     4191       +4     
- Partials     6900     6911      +11     
Impacted Files Coverage Δ
Core/include/Acts/Geometry/CuboidVolumeBuilder.hpp 33.33% <ø> (ø)
Core/src/Material/Interactions.cpp 75.52% <0.00%> (-0.92%) ⬇️
Core/src/TrackFitting/GainMatrixUpdater.cpp 14.28% <0.00%> (-0.87%) ⬇️
Core/src/Utilities/FpeMonitor.cpp 64.51% <64.51%> (ø)
...Propagator/detail/PointwiseMaterialInteraction.hpp 97.22% <100.00%> (+0.07%) ⬆️
Core/include/Acts/Utilities/Helpers.hpp 66.12% <100.00%> (+0.56%) ⬆️
Core/src/Geometry/CuboidVolumeBuilder.cpp 36.88% <100.00%> (+1.05%) ⬆️
Core/src/Material/MaterialGridHelper.cpp 69.65% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger removed the 🚧 WIP Work-in-progress label Dec 12, 2022
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you ad a little summary in the description?

I dropped a few comments. otherwise should be good to go

.github/workflows/builds.yml Outdated Show resolved Hide resolved
CI/physmon/physmon.py Outdated Show resolved Hide resolved
CI/physmon/physmon.py Outdated Show resolved Hide resolved
CI/physmon/physmon.py Outdated Show resolved Hide resolved
Core/CMakeLists.txt Outdated Show resolved Hide resolved
Examples/Scripts/Python/full_chain_odd.py Show resolved Hide resolved
Examples/Scripts/Python/geometry.py Outdated Show resolved Hide resolved
Tests/UnitTests/Core/Utilities/FpeMonitorTests.cpp Outdated Show resolved Hide resolved
Tests/UnitTests/Core/Utilities/FpeMonitorTests.cpp Outdated Show resolved Hide resolved
thirdparty/backward-cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 651f970 into acts-project:main Dec 19, 2022
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
kodiakhq bot pushed a commit that referenced this pull request Feb 9, 2023
These lines were changed with #1649 but I'm afraid `deltaRMiddleMaxSPRange` was forgotten

/cc @paulgessinger and @LuisFelipeCoelho
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants