Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Do not require codecov anymore for automerge #1652

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

benjaminhuth
Copy link
Member

Codecov seems sometimes not update anymore on PRs with automerge label, so they never get merged and need to be merged manually in the end...
I'm not sure what exactly causes these problems, but I think it would not be to problematic to relax the requirements on this...

@benjaminhuth benjaminhuth added this to the next milestone Nov 4, 2022
@benjaminhuth benjaminhuth added the Infrastructure Changes to build tools, continous integration, ... label Nov 4, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

📊 Physics performance monitoring for e7fec6a

Full report
CKF: seeded, truth smeared, truth estimated
IVF: seeded, truth smeared, truth estimated
Ambiguity resolution
Truth tracking

Vertexing

IVF seeded

IVF truth smeared

IVF truth estimated

CKF

seeded

truth smeared

truth estimated

Ambiguity resolution

seeded

Truth tracking

Truth tracking

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #1652 (e7fec6a) into main (ac6f337) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1652   +/-   ##
=======================================
  Coverage   48.54%   48.54%           
=======================================
  Files         384      384           
  Lines       21042    21042           
  Branches     9693     9693           
=======================================
  Hits        10214    10214           
  Misses       4106     4106           
  Partials     6722     6722           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 12c2774 into acts-project:main Nov 4, 2022
@benjaminhuth benjaminhuth deleted the ci/codecov-not-required branch November 4, 2022 12:17
@github-actions github-actions bot removed the automerge label Nov 4, 2022
@paulgessinger paulgessinger modified the milestones: next, v21.1.0 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants