Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modernize & add checks to Acts::TrackingGeometryBuilder #1656

Merged

Conversation

benjaminhuth
Copy link
Member

After yesterday's chat in the mattermost channel I found it might be worth to refactor this code a bit. Adds the use of std::make_unique and adds some checks with more or less meaningful exceptions.

@benjaminhuth benjaminhuth added Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module labels Nov 4, 2022
@benjaminhuth benjaminhuth added this to the next milestone Nov 4, 2022
CI/physmon/physmon.py Outdated Show resolved Hide resolved
@benjaminhuth benjaminhuth added the 🚧 WIP Work-in-progress label Nov 7, 2022
@stale
Copy link

stale bot commented Dec 21, 2022

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@stale stale bot added the Stale label Dec 21, 2022
@stale stale bot removed the Stale label Jan 18, 2023
@andiwand andiwand self-assigned this Jan 18, 2023
@github-actions
Copy link

github-actions bot commented Jan 18, 2023

📊 Physics performance monitoring for 82defa7

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1656 (bb970dc) into main (fabf9ac) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

❗ Current head bb970dc differs from pull request most recent head 82defa7. Consider uploading reports for the commit 82defa7 to get more accurate results

@@            Coverage Diff             @@
##             main    #1656      +/-   ##
==========================================
- Coverage   49.59%   49.58%   -0.01%     
==========================================
  Files         407      407              
  Lines       22600    22601       +1     
  Branches    10305    10307       +2     
==========================================
- Hits        11208    11207       -1     
- Misses       4211     4213       +2     
  Partials     7181     7181              
Impacted Files Coverage Δ
Core/src/Geometry/TrackingGeometryBuilder.cpp 52.38% <33.33%> (-7.62%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth benjaminhuth removed the 🚧 WIP Work-in-progress label Jan 18, 2023
@kodiakhq kodiakhq bot merged commit f44f1da into acts-project:main Jan 18, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
@benjaminhuth benjaminhuth deleted the refactor/tracking-geometry-builder branch February 22, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants