-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: modernize & add checks to Acts::TrackingGeometryBuilder
#1656
refactor: modernize & add checks to Acts::TrackingGeometryBuilder
#1656
Conversation
This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs. |
📊 Physics performance monitoring for 82defa7Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
Codecov Report
@@ Coverage Diff @@
## main #1656 +/- ##
==========================================
- Coverage 49.59% 49.58% -0.01%
==========================================
Files 407 407
Lines 22600 22601 +1
Branches 10305 10307 +2
==========================================
- Hits 11208 11207 -1
- Misses 4211 4213 +2
Partials 7181 7181
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
After yesterday's chat in the mattermost channel I found it might be worth to refactor this code a bit. Adds the use of
std::make_unique
and adds some checks with more or less meaningful exceptions.