refactor: replace track params with trajectories in examples #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1670 +/- ##
=======================================
Coverage 48.54% 48.54%
=======================================
Files 383 383
Lines 20976 20976
Branches 9641 9641
=======================================
Hits 10182 10182
Misses 4119 4119
Partials 6675 6675 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 116e29bFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedCKFCKF seededCKF truth_smearedCKF truth_estimatedAmbiguity resolutionseededTruth trackingTruth tracking |
benjaminhuth
requested changes
Nov 10, 2022
Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackSelector.cpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackSelector.cpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackSelector.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/Vertexing/src/IterativeVertexFinderAlgorithm.cpp
Outdated
Show resolved
Hide resolved
andiwand
added
Component - Examples
|
looks like this is passing now @benjaminhuth cc @paulgessinger if you want to check this out |
benjaminhuth
approved these changes
Nov 11, 2022
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
…oject#1670) somehow we ended up passing through track parameters and trajectory tips through our algorithm chain which can be replaced by trajectories the only caveat is particle smearing which will produce track parameters which should be passed down the chain. so track selector and vertexing will still except track parameters as an input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
somehow we ended up passing through track parameters and trajectory tips through our algorithm chain which can be replaced by trajectories
the only caveat is particle smearing which will produce track parameters which should be passed down the chain. so track selector and vertexing will still except track parameters as an input