feat: Support space points writing #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJPfleger
reviewed
Nov 11, 2022
Examples/Io/Root/include/ActsExamples/Io/Root/RootSpacepointWriter.hpp
Outdated
Show resolved
Hide resolved
andiwand
approved these changes
Nov 11, 2022
Examples/Io/Root/include/ActsExamples/Io/Root/RootSpacepointWriter.hpp
Outdated
Show resolved
Hide resolved
andiwand
approved these changes
Nov 11, 2022
|
Thanks @andiwand for having a look. I have addressed them. Have not used the editing feature in the gitlab. Have "experiences" with it. |
Codecov Report
@@ Coverage Diff @@
## main #1671 +/- ##
=======================================
Coverage 48.54% 48.54%
=======================================
Files 383 383
Lines 20976 20976
Branches 9641 9641
=======================================
Hits 10182 10182
Misses 4119 4119
Partials 6675 6675 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for d1a282bFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedCKFCKF seededCKF truth_smearedCKF truth_estimatedAmbiguity resolutionseededTruth trackingTruth tracking |
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
This PR adds python binding for integrating Space Points writing as CSV in python scripts. It also adds writer algorithm to wite Space Points in ROOT file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds python binding for integrating Space Points writing as CSV in python scripts.
It also adds writer algorithm to wite Space Points in ROOT file.