Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add precondition check for MTJ applyBackward and visitBackwards #1685

Merged

Conversation

benjaminhuth
Copy link
Member

If not checked, this leads to a segfault by trying to access the proxy or the previous proxy.

@benjaminhuth benjaminhuth added Component - Core Affects the Core module Improvement Changes to an existing feature labels Nov 22, 2022
@benjaminhuth benjaminhuth added this to the next milestone Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1685 (52ea348) into main (89c62ea) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1685      +/-   ##
==========================================
- Coverage   48.96%   48.95%   -0.01%     
==========================================
  Files         397      397              
  Lines       21505    21509       +4     
  Branches     9802     9806       +4     
==========================================
  Hits        10530    10530              
- Misses       4179     4181       +2     
- Partials     6796     6798       +2     
Impacted Files Coverage Δ
Core/include/Acts/EventData/MultiTrajectory.hpp 68.87% <0.00%> (-0.55%) ⬇️
Core/include/Acts/EventData/MultiTrajectory.ipp 65.38% <0.00%> (-1.73%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Nov 22, 2022

📊 Physics performance monitoring for 52ea348

🟥 ERROR The result has missing elements!
This is likely a physmon job failure

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

❌ Seeding truth_smeared

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit 881b5c0 into acts-project:main Nov 23, 2022
pbutti pushed a commit to pbutti/acts that referenced this pull request Dec 13, 2022
…ckwards` (acts-project#1685)

If not checked, this leads to a segfault by trying to access the proxy or the previous proxy.
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
…ckwards` (acts-project#1685)

If not checked, this leads to a segfault by trying to access the proxy or the previous proxy.
@benjaminhuth benjaminhuth deleted the refactor/check-precondition-mtj branch February 22, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants