feat: Improve const correctness of MultiTrajectory #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `const TrackStateProxy&` should behave like `ConstTrackStateProxy`.
benjaminhuth
requested changes
Nov 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #1698 +/- ##
==========================================
+ Coverage 48.95% 49.02% +0.06%
==========================================
Files 397 397
Lines 21509 21558 +49
Branches 9806 9817 +11
==========================================
+ Hits 10530 10568 +38
Misses 4181 4181
- Partials 6798 6809 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 323b386Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
pbutti
pushed a commit
to pbutti/acts
that referenced
this pull request
Dec 13, 2022
Now `const TrackStateProxy&` should behave like `ConstTrackStateProxy`.
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
Now `const TrackStateProxy&` should behave like `ConstTrackStateProxy`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
const TrackStateProxy&should behave likeConstTrackStateProxy.