fix: Change theta and eta calls on only 3D Vectors #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The theta and eta calls could be done on 4D vectors. While they are well defined on a LorentzVector, for example, this was not the intended behaviour of the function, which supposedly should run only on 3D vectors. In particular eta on a 4-momentum was returning the wrong results. Changed the checks on rows to be exactly 3. In the future the eta/theta could be properly defined on 4d vectors as well by choosing a convention for the indices of the 4D vector
Codecov Report
@@ Coverage Diff @@
## main #1706 +/- ##
=======================================
Coverage 49.28% 49.28%
=======================================
Files 398 398
Lines 21787 21787
Branches 9884 9884
=======================================
Hits 10737 10737
Misses 4201 4201
Partials 6849 6849
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 79b7e20Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
|
Ah you might need to add @pbutti to your CI-bridge-allow-list @paulgessinger ? |
pbutti
added a commit
to pbutti/acts
that referenced
this pull request
Dec 13, 2022
The theta and eta calls could be done on 4D vectors. While they are well defined on a LorentzVector, for example, this was not the intended behaviour of the function, which supposedly should run only on 3D vectors. In particular eta on a 4-momentum was returning the wrong results. Changed the checks on rows to be exactly 3. In the future the eta/theta could be properly defined on 4d vectors as well by choosing a convention for the indices of the 4D vector
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
The theta and eta calls could be done on 4D vectors. While they are well defined on a LorentzVector, for example, this was not the intended behaviour of the function, which supposedly should run only on 3D vectors. In particular eta on a 4-momentum was returning the wrong results. Changed the checks on rows to be exactly 3. In the future the eta/theta could be properly defined on 4d vectors as well by choosing a convention for the indices of the 4D vector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theta and eta calls could be done on 4D vectors. While they are well defined on a LorentzVector, for example, this was not the intended behaviour of the function, which supposedly should run only on 3D vectors. In particular eta on a 4-momentum was returning the wrong results. Changed the checks on rows to be exactly 3. In the future the eta/theta could be properly defined on 4d vectors as well by choosing a convention for the indices of the 4D vector