Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential floating point over/underflow #1709

Merged
merged 10 commits into from
Dec 8, 2022

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Dec 5, 2022

fixes potential floating point over/underflow cases. discovered by regex search (.+)\s+\*\s+\1\s+[<>=]

@andiwand andiwand added the 🚧 WIP Work-in-progress label Dec 5, 2022
@andiwand andiwand added this to the next milestone Dec 5, 2022
@andiwand andiwand changed the title fix: fp abs compare fix: potential floating point over/underflow compare Dec 5, 2022
@andiwand andiwand changed the title fix: potential floating point over/underflow compare fix: potential floating point over/underflow Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

📊 Physics performance monitoring for 36abf81

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1709 (88a81b2) into main (e2ed9fb) will not change coverage.
The diff coverage is 65.38%.

❗ Current head 88a81b2 differs from pull request most recent head 36abf81. Consider uploading reports for the commit 36abf81 to get more accurate results

@@           Coverage Diff           @@
##             main    #1709   +/-   ##
=======================================
  Coverage   49.28%   49.28%           
=======================================
  Files         398      398           
  Lines       21787    21787           
  Branches     9884     9884           
=======================================
  Hits        10737    10737           
  Misses       4201     4201           
  Partials     6849     6849           
Impacted Files Coverage Δ
Core/src/Surfaces/DiscSurface.cpp 30.96% <0.00%> (ø)
Core/src/Surfaces/PlaneSurface.cpp 54.25% <0.00%> (ø)
...ore/include/Acts/Geometry/GeometryObjectSorter.hpp 46.66% <28.57%> (ø)
Core/src/Surfaces/ConeSurface.cpp 34.59% <66.66%> (ø)
Core/src/Surfaces/CylinderSurface.cpp 37.28% <80.00%> (+0.35%) ⬆️
Core/include/Acts/Surfaces/detail/PlanarHelper.hpp 50.00% <100.00%> (ø)
Core/src/Geometry/CylinderVolumeHelper.cpp 29.87% <100.00%> (ø)
Core/src/Geometry/TrackingVolume.cpp 44.87% <100.00%> (-0.17%) ⬇️
Core/src/Surfaces/IntersectionHelper2D.cpp 30.26% <100.00%> (ø)
Core/src/Surfaces/LineSurface.cpp 35.84% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andiwand
Copy link
Contributor Author

andiwand commented Dec 7, 2022

should we get this in @paulgessinger ?

@andiwand andiwand removed the 🚧 WIP Work-in-progress label Dec 7, 2022
@kodiakhq kodiakhq bot merged commit 440f092 into acts-project:main Dec 8, 2022
@github-actions github-actions bot removed the automerge label Dec 8, 2022
pbutti pushed a commit to pbutti/acts that referenced this pull request Dec 13, 2022
fixes potential floating point over/underflow cases. discovered by regex search `(.+)\s+\*\s+\1\s+[<>=]`
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
fixes potential floating point over/underflow cases. discovered by regex search `(.+)\s+\*\s+\1\s+[<>=]`
@andiwand andiwand deleted the fix-fp-abs-compare branch January 24, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants