feat: Optionally decorate geometry dumps to json.

[goetzgaycken]

Added the possibility to pass a decorator to the json converter to add extra attributes to the json dump of certain objects. Decorator interfaces are defined for adding attributes to surface and volume or their material dumps.

One use case is to extend the json dumps of the ATLAS tracking geometry with the ATLAS detector element IDs.

The PR changes interfaces in Plugins/Json.

[stale]

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

[codecov]

Codecov Report

Merging #1732 (dc46faa) into main (f44f1da) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1732   +/-   ##
=======================================
  Coverage   49.54%   49.54%           
=======================================
  Files         407      407           
  Lines       22618    22618           
  Branches    10318    10318           
=======================================
  Hits        11207    11207           
  Misses       4230     4230           
  Partials     7181     7181           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[niermann999]

Looks good in general

[goetzgaycken]

changes from 8352a7a to d318bc2 :

• rebase to main of 2023-01-17 8:05
• explicit nullptr comparison for get<0>(src)
• use std::false_type instead of "reinventing" the construct
• updated copyright message of changed files to -2023

[goetzgaycken]

Changes from d318bc2 to e3ca98d

• Fix compiler warning concerning potentially unused argument (if constrexpr(...) might disable some code)
• Fix doxygen warning about undocumented parameter

[github-actions]

📊 Physics performance monitoring for dc46faa

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[goetzgaycken]

changes from e3ca98d to 1bc9e7a:

• implement clang-format differences

[goetzgaycken]

changes from 1bc9e7a to c007e1d :

[goetzgaycken]

changes from 1bc9e7a to c007e1d :

• removed remnant from an early idea.

[goetzgaycken]

changes from 4b72276 to b2bcd7a :

• removed unused forward declarations.

[goetzgaycken]

concerning the test coverage:

• there are some new lines which cannot be tested by a unit test because they will provoke compilation failures. Not sure how the lines are counted this would be something between 2 and 18 lines.
• then there are some input adapters (between 12 and 34 lines), which could be tested by writing a unit test for the tracking geometry to json conversion. The latter would however require a dummy tracking geometry. The resulting "unit" test would be more an integration test than a unit test.
• alternatively I could just call the adapters, but that would not test much.

[paulgessinger]

Seems to me like the coverage decrease is somehow still from the recent change to KD-tree, maybe we should override the coverage here.

[goetzgaycken]

Seems to me like the coverage decrease is somehow still from the recent change to KD-tree, maybe we should override the coverage here.

can I ran the coverage analysis locally ?

[paulgessinger]

Seems to me like the coverage decrease is somehow still from the recent change to KD-tree, maybe we should override the coverage here.

can I ran the coverage analysis locally ?

This full analysis suite run by codecov, no. You can run the coverage itself locally (I think cmake --build --target coverage) which gives you coverage output that can be processed and visualized separately. I haven't run this locally in quite a while either.