feat: track 2d/z and track 3d signed lifetimes #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
- Coverage 49.66% 49.65% -0.01%
==========================================
Files 403 404 +1
Lines 22406 22435 +29
Branches 10240 10258 +18
==========================================
+ Hits 11127 11141 +14
+ Misses 4135 4132 -3
- Partials 7144 7162 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I will fix the clang-format and the docs. |
📊 Physics performance monitoring for 186f008Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
There was a problem hiding this comment.
Hey @pbutti, can you fix the format check. Also would you consider adding two tiny unit tests to ImpactPointEstimatoeTests.cpp just so we have this functionality covered.
pbutti
force-pushed
the
feature-track2DZlifetimesSign
branch
from
187fce7
to
eac937c
Compare
paulgessinger
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add couple of methods from the Athena TrackToVertexIPEstimator. In particular the 3d, 2d and Z signed lifetimes with respect to a given direction, i.e. a jet direction, are provided.
The computation follows the methods largely used by atlas here:
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Tracking/TrkVertexFitter/TrkVertexFitterUtils/src/TrackToVertexIPEstimator.cxx#0230
The interface is kept as simple as possible, without using the intermediate VertexFinder::State.