feat: Fully configurable layer envelopes #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Physics performance monitoring for 8e0213dFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #1751 +/- ##
=======================================
Coverage 49.14% 49.14%
=======================================
Files 395 395
Lines 21800 21802 +2
Branches 9953 9953
=======================================
+ Hits 10713 10715 +2
Misses 4187 4187
Partials 6900 6900
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
approved these changes
Dec 19, 2022
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
This PR is to allow for fully configure the CuboidVolumeBuilder to define the envelope of the various layers. Allowing Navigation layers to be wider than just the size of the sensitive surfaces can help with problems seen in issue acts-project#1596 to account for the fact that the Navigator will extrapolate linearly from the last state, not taking into account that the track will bend. This is only relevant in telescope geometries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to allow for fully configure the CuboidVolumeBuilder to define the envelope of the various layers.
Allowing Navigation layers to be wider than just the size of the sensitive surfaces can help with problems seen in issue
#1596 to account for the fact that the Navigator will extrapolate linearly from the last state, not taking into account that the track will bend. This is only relevant in telescope geometries.