Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make Examples binaries optional #1754

Merged

Conversation

benjaminhuth
Copy link
Member

This adds the CMake option ACTS_BUILD_EXAMPLES_BINARIES that is OFF by default.

Also adds a bit of logic so that Boost::progarm_options and Boost::unit_test_framework are only imported if they are required. This way, a Acts build without tests, binaries or analysis scripts does only require boost headers.

This has also some impact on build times, I save ~6 minutes for make -j1...

@benjaminhuth benjaminhuth added Impact - Minor Nuissance bug and/or affects only a single module Component - Examples Affects the Examples module labels Dec 16, 2022
@benjaminhuth benjaminhuth added this to the next milestone Dec 16, 2022
@benjaminhuth benjaminhuth changed the title refactor: Make Examples optional refactor: Make Examples binaries optional Dec 16, 2022
@github-actions
Copy link

github-actions bot commented Dec 16, 2022

📊 Physics performance monitoring for c8c6ac3

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #1754 (985bb3b) into main (d1ce5a5) will not change coverage.
The diff coverage is n/a.

❗ Current head 985bb3b differs from pull request most recent head c8c6ac3. Consider uploading reports for the commit c8c6ac3 to get more accurate results

@@           Coverage Diff           @@
##             main    #1754   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files         406      406           
  Lines       22565    22565           
  Branches    10305    10305           
=======================================
  Hits        11239    11239           
  Misses       4138     4138           
  Partials     7188     7188           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets get this in

CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@andiwand andiwand self-requested a review January 11, 2023 10:02
@kodiakhq kodiakhq bot merged commit 5dbdf72 into acts-project:main Jan 11, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
@benjaminhuth benjaminhuth deleted the refactor/make-binaries-optional branch February 22, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants