refactor!: Changes to SeedFinderOrthogonal to allow reuse of the object

[tboldagh]

This PR applies similar changes to these in #1693 . As a result the SeedFinderOrthogonal does not need to be recreated for every event.

Closes #1690

BREAKING CHANGE
Method to crate OthogonalSeedFinder and createSeeds are modified. The former does not take SeedOptions while the later does now.

[github-actions]

📊 Physics performance monitoring for ee3424b

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[codecov]

Codecov Report

Merging #1757 (5b5b4ab) into main (fabf9ac) will not change coverage.
The diff coverage is n/a.

❗ Current head 5b5b4ab differs from pull request most recent head ee3424b. Consider uploading reports for the commit ee3424b to get more accurate results

@@           Coverage Diff           @@
##             main    #1757   +/-   ##
=======================================
  Coverage   49.59%   49.59%           
=======================================
  Files         407      407           
  Lines       22600    22600           
  Branches    10305    10305           
=======================================
  Hits        11208    11208           
  Misses       4211     4211           
  Partials     7181     7181           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[stephenswat]

Looks like an excellent change.

[paulgessinger]

Ah, the CI doesn't run while there are conflicts. After the conflicts have been resolved, you'd be able to pull the ROOT hash from the CI to update.

[tboldagh]

Ah, the CI doesn't run while there are conflicts. After the conflicts have been resolved, you'd be able to pull the ROOT hash from the CI to update.

I have to say that the gitlab CI visualisation is way simpler to digest.

[stephenswat]

Hi @tboldagh, is this ready to go? I'm excited to merge it in. 😄

[tboldagh]

Hi @tboldagh, is this ready to go? I'm excited to merge it in. 😄

Yes. However I am still GitHub-dumb and not sure if all is good. I.e. there are changes im plots (like the one attached) that the CI did not complain about:

[paulgessinger]

The physmon histogram comparison tries to be smart and doesn't check them for bit-identicality (somewhat similar to dcube).

Is this histogram from the reference file you updated?

[tboldagh]

No, Another one. (Orthogonal seeding.) The updated one match perfectly.

[paulgessinger]

Ok so a change there is expected. You can either update that reference file as well or we merge as is.

[tboldagh]

Ok so a change there is expected. You can either update that reference file as well or we merge as is.

I think it is better to update to reduce other people confusion. Doing that now.