Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More robust navigation with bent tracks #1769

Merged

Conversation

benjaminhuth
Copy link
Member

This PR adds an option to the Acts::Navigator to disable the boundary check on layer resolval. It also adds an integration test that does check exactely this in a simple cuboid geometry. @pbutti could you check if this solves your problem?

cc @paulgessinger @asalzburger

should fix #1596

@benjaminhuth benjaminhuth added Component - Core Affects the Core module Improvement Changes to an existing feature labels Dec 22, 2022
@benjaminhuth benjaminhuth added this to the next milestone Dec 22, 2022
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's "bent" tracks.

Tests/IntegrationTests/PropagationBendedTracks.cpp Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/Navigator.hpp Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #1769 (8974c57) into main (56cbaf4) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #1769   +/-   ##
=======================================
  Coverage   49.83%   49.83%           
=======================================
  Files         406      406           
  Lines       22532    22532           
  Branches    10280    10280           
=======================================
  Hits        11228    11228           
  Misses       4131     4131           
  Partials     7173     7173           
Impacted Files Coverage Δ
Core/include/Acts/Propagator/Navigator.hpp 54.36% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth benjaminhuth changed the title feat: More robust navigation with bended tracks feat: More robust navigation with bent tracks Dec 23, 2022
@github-actions
Copy link

github-actions bot commented Jan 10, 2023

📊 Physics performance monitoring for 8974c57

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more typos, otherwise good to go!

Core/include/Acts/Propagator/Navigator.hpp Show resolved Hide resolved
Tests/IntegrationTests/PropagationBentTracks.cpp Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 70dc953 into acts-project:main Jan 16, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
@benjaminhuth benjaminhuth deleted the feature/navigation-bended-tracks branch February 22, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigator: Resolving surfaces/layers/boundaries with bending tracks
3 participants