Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GeoID hook from python & ODD hook #1779

Merged

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Jan 10, 2023

This PR adds a mechanism to add a geometry identifier hook directly from python, e.g. in odd.py (thanks @paulgessinger for the suggestion with the py::object). So there is no need to awkwardly define a ODD-specific hook somewhere in the C++ code.

I think this is not breaking, even though it changes Acts::GeometryIdentifierHook from a typedef to a std::function to a virtual baseclass. However, in docs/versioning.rst the Geometry module is not defined as "subject of the versioning".

The extra-bits in the ODD are now set like this:

image

Thanks also @Corentin-Allaire for the preparing work! I would suggest to close #1696 after this is merged.

cc @asalzburger

@kodiakhq kodiakhq bot merged commit fabf9ac into acts-project:main Jan 18, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
@benjaminhuth benjaminhuth deleted the experimental/corentain-odd-geoid-hook branch February 22, 2023 07:41
wdconinc added a commit to eic/EICrecon that referenced this pull request Oct 25, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Oct 26, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Oct 30, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Nov 5, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Nov 6, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Nov 15, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Nov 15, 2023
wdconinc added a commit to eic/EICrecon that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Feature Development to integrate a new feature Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants