-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GeoID hook from python & ODD hook #1779
Merged
kodiakhq
merged 47 commits into
acts-project:main
from
benjaminhuth:experimental/corentain-odd-geoid-hook
Jan 18, 2023
Merged
feat: GeoID hook from python & ODD hook #1779
kodiakhq
merged 47 commits into
acts-project:main
from
benjaminhuth:experimental/corentain-odd-geoid-hook
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/acts into extraID-Encap-ODD
paulgessinger
approved these changes
Jan 17, 2023
paulgessinger
approved these changes
Jan 18, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 16, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 17, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 25, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 25, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 25, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 26, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 30, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 5, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 6, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 15, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 15, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Feature
Development to integrate a new feature
Impact - Minor
Nuissance bug and/or affects only a single module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism to add a geometry identifier hook directly from python, e.g. in
odd.py
(thanks @paulgessinger for the suggestion with thepy::object
). So there is no need to awkwardly define a ODD-specific hook somewhere in the C++ code.I think this is not breaking, even though it changes
Acts::GeometryIdentifierHook
from a typedef to astd::function
to a virtual baseclass. However, indocs/versioning.rst
the Geometry module is not defined as "subject of the versioning".The extra-bits in the ODD are now set like this:
Thanks also @Corentin-Allaire for the preparing work! I would suggest to close #1696 after this is merged.
cc @asalzburger