Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump actsvg to v0.4.28 #1797

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Conversation

andiwand
Copy link
Contributor

this should silence a bunch of compiler warnings

@andiwand andiwand added Impact - Minor Nuissance bug and/or affects only a single module Component - Plugins Affects one or more Plugins labels Jan 24, 2023
@andiwand andiwand added this to the next milestone Jan 24, 2023
@andiwand andiwand changed the title deps: bump actsvg to v0.4.28 chore: bump actsvg to v0.4.28 Jan 24, 2023
@github-actions
Copy link

github-actions bot commented Jan 24, 2023

📊 Physics performance monitoring for 9a21c24

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #1797 (6bc10d1) into main (d15f103) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 6bc10d1 differs from pull request most recent head 9a21c24. Consider uploading reports for the commit 9a21c24 to get more accurate results

@@            Coverage Diff             @@
##             main    #1797      +/-   ##
==========================================
- Coverage   49.56%   49.54%   -0.02%     
==========================================
  Files         407      407              
  Lines       22618    22618              
  Branches    10316    10318       +2     
==========================================
- Hits        11211    11207       -4     
- Misses       4227     4230       +3     
- Partials     7180     7181       +1     
Impacted Files Coverage Δ
Core/include/Acts/Propagator/DirectNavigator.hpp 60.46% <0.00%> (-4.66%) ⬇️
Core/include/Acts/Propagator/Navigator.hpp 54.36% <0.00%> (-0.68%) ⬇️
Core/src/Utilities/Logger.cpp 28.00% <0.00%> (-0.58%) ⬇️
Core/src/Geometry/TrackingVolume.cpp 45.79% <0.00%> (-0.49%) ⬇️
Core/include/Acts/Geometry/Layer.hpp 100.00% <0.00%> (ø)
Core/include/Acts/Geometry/TrackingVolume.hpp 70.73% <0.00%> (ø)
Core/include/Acts/Geometry/TrackingGeometry.hpp 100.00% <0.00%> (ø)
.../include/Acts/Geometry/TrackingGeometryBuilder.hpp 100.00% <0.00%> (ø)
Core/include/Acts/TrackFitting/KalmanFitter.hpp 43.19% <0.00%> (+0.12%) ⬆️
Core/include/Acts/Utilities/Logger.hpp 58.71% <0.00%> (+0.22%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 20a7d0d into acts-project:main Feb 3, 2023
@github-actions github-actions bot removed the automerge label Feb 3, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.2.0 Feb 6, 2023
@andiwand andiwand deleted the bump-actsvg branch February 14, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants