feat: KalmanFitter marks missed surfaces as outliers #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already walk all states and check if they were passed again (to remove the smoothed parameters), we can use the same spot to mark as outliers
|
/cc @CarloVarni |
Codecov Report
@@ Coverage Diff @@
## main #1809 +/- ##
==========================================
- Coverage 49.55% 49.54% -0.01%
==========================================
Files 407 407
Lines 22625 22626 +1
Branches 10321 10322 +1
==========================================
Hits 11211 11211
Misses 4230 4230
- Partials 7184 7185 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 2eb6f83Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
andiwand
approved these changes
Jan 30, 2023
|
@andiwand somehow the review got dismissed, can you try again? |
andiwand
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already walk all states and check if they were passed again (to remove the smoothed parameters), we can use the same spot to mark as outliers