refactor: Remove LoggerWrapper in favor of Logger refs #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a residual un-namespaced target we linked against. Only exists if we build nlohmann_json ourselves.
Codecov Report
@@ Coverage Diff @@
## main #1812 +/- ##
==========================================
+ Coverage 49.54% 49.56% +0.01%
==========================================
Files 407 407
Lines 22626 22618 -8
Branches 10322 10316 -6
==========================================
Hits 11211 11211
+ Misses 4230 4227 -3
+ Partials 7185 7180 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 4f058c5Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
andiwand
approved these changes
Jan 30, 2023
Core/include/Acts/EventData/detail/CorrectedTransformationFreeToBound.hpp
Show resolved
Hide resolved
Plugins/DD4hep/include/Acts/Plugins/DD4hep/ConvertDD4hepMaterial.hpp
Outdated
Show resolved
Hide resolved
andiwand
approved these changes
Jan 31, 2023
andiwand
approved these changes
Feb 1, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 16, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 17, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 25, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 25, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 25, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 26, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Oct 30, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 5, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 6, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 15, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 15, 2023
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To harmonize / simplify the ways that loggers are used, this PR removes
LoggerWrapper. To support the case of e.g. functions optionally accepting a logger, we can useconst Logger&and default it togetDummyLogger. SincegetDummyLoggerreturns a reference to a logger instance of static lifetime, all the arguments should be safe, even if they are retained (I think).