Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: collapse material tracks #1816

Merged
merged 9 commits into from
Feb 3, 2023
Merged

feat: collapse material tracks #1816

merged 9 commits into from
Feb 3, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Feb 1, 2023 •
edited

  • option to collapse material tracks
  • fix and simplify material composition script
  • fix typos

@andiwand andiwand added the Component - Examples Affects the Examples module label Feb 1, 2023
@andiwand andiwand added this to the next milestone Feb 1, 2023
@andiwand andiwand changed the title feature: collapse material tracks feat: collapse material tracks Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023 •
edited

📊 Physics performance monitoring for 2834dc8

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Feb 1, 2023 •
edited

Codecov Report

Merging #1816 (2834dc8) into main (13f15e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1816   +/-   ##
=======================================
  Coverage   49.53%   49.53%           
=======================================
  Files         407      407           
  Lines       22629    22629           
  Branches    10326    10326           
=======================================
  Hits        11210    11210           
  Misses       4230     4230           
  Partials     7189     7189
Impacted Files Coverage Δ
Core/include/Acts/Geometry/Extent.hpp 95.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

andiwand and others added 3 commits February 3, 2023 10:06
@andiwand @AJPfleger
Update Examples/Io/Root/include/ActsExamples/Io/Root/RootMaterialTrac…
7e7e60d 
…kWriter.hpp

Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
@andiwand
fix typo
04d6a97
@andiwand
remove stuff
12b1bd8
benjaminhuth
benjaminhuth approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@kodiakhq kodiakhq bot merged commit 2625e6c into acts-project:main Feb 3, 2023
@github-actions github-actions bot removed the automerge label Feb 3, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.2.0 Feb 6, 2023
@andiwand andiwand deleted the feature-collapse-material-tracks branch February 14, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger requested changes

@benjaminhuth benjaminhuth benjaminhuth approved these changes

Assignees
No one assigned
Labels
Component - Examples Affects the Examples module
Projects
None yet
Milestone
v23.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andiwand @benjaminhuth @AJPfleger @paulgessinger