Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set up ODD together with python if possible #1830

Merged

Conversation

benjaminhuth
Copy link
Member

This modifies the setup.sh script a bit so it tries to look for the ODD and add its directory to the LD_LIBRARY_PATH.

@benjaminhuth benjaminhuth added Improvement Changes to an existing feature Impact - Minor Nuissance bug and/or affects only a single module Component - Examples Affects the Examples module labels Feb 6, 2023
@benjaminhuth benjaminhuth added this to the next milestone Feb 6, 2023
@paulgessinger
Copy link
Member

The ODD repository also has a setup script. Maybe it would be better if this setup checks if that other setup is present, and just sources that?

@benjaminhuth
Copy link
Member Author

Hmm this this_odd.sh script seems to just add /usr/local/lib64 (or whatever cmake was configured as install prefix I think) to LD_LIBRARY_PATH.

The use case of the Acts python setup.sh script (at least for me) is for the case ACTS is not installed (which at the moment for the examples also would not work I think).

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

📊 Physics performance monitoring for 4608f16

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1830 (4608f16) into main (9b60cd0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1830   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         407      407           
  Lines       22646    22646           
  Branches    10334    10334           
=======================================
  Hits        11210    11210           
  Misses       4247     4247           
  Partials     7189     7189           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Corentin-Allaire
Copy link
Contributor

Just to comment here on using the ODD with MacOs, it work on my machine.
Maybe doing some thing like this would work here :
export DYLD_LIBRARY_PATH+=:$odd_dir export DD4HEP_LIBRARY_PATH+=:$odd_dir

@paulgessinger
Copy link
Member

Just to comment here on using the ODD with MacOs, it work on my machine. Maybe doing some thing like this would work here : export DYLD_LIBRARY_PATH+=:$odd_dir export DD4HEP_LIBRARY_PATH+=:$odd_dir

How do you run then? I have the problem that DYLD_LIBRARY_PATH gets cleared and then DD4hep freaks out.

@Corentin-Allaire
Copy link
Contributor

Just to comment here on using the ODD with MacOs, it work on my machine. Maybe doing some thing like this would work here : export DYLD_LIBRARY_PATH+=:$odd_dir export DD4HEP_LIBRARY_PATH+=:$odd_dir

How do you run then? I have the problem that DYLD_LIBRARY_PATH gets cleared and then DD4hep freaks out.

I just call the python code afterward nothing special. When does it get cleared for you ? (if you want we can discuss this directly via mattermost, might be faster )

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! I will open one for the macOs side later.

@kodiakhq kodiakhq bot merged commit 2a5c4d5 into acts-project:main Feb 15, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
@benjaminhuth benjaminhuth deleted the feature/set-up-odd-with-python branch February 22, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants