Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: persist ACTS barcodes in G4 sim #1842

Merged
merged 10 commits into from
Feb 9, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Feb 9, 2023

particle barcodes did not make sense after G4 sim because they were just counted upwards without paying attention to the semantics of the bits in the barcode.

this pr adds persistence to the barcodes by storing a mapping in the G4 specific event store. also the particle generation counter is increased with each secondary process

@andiwand andiwand added the Component - Examples Affects the Examples module label Feb 9, 2023
@andiwand andiwand added this to the next milestone Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

📊 Physics performance monitoring for 2f172d3

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done! I think we're getting closer to make Geant4 a drop-in replacement of FATRAS!

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #1842 (2f172d3) into main (d18a2e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1842   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         407      407           
  Lines       22646    22646           
  Branches    10334    10334           
=======================================
  Hits        11210    11210           
  Misses       4247     4247           
  Partials     7189     7189           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pbutti
Copy link
Contributor

pbutti commented Feb 9, 2023

Just to confirm: I suppose this fixes these errors?

10:08:01    RootTrajecto   WARNING   Truth particle with barcode = 37 not found!
10:08:01    RootTrajecto   WARNING   Truth particle with barcode = 2 not found!
10:08:01    RootTrajecto   WARNING   Truth particle with barcode = 2 not found!
10:08:01    RootTrajecto   WARNING   Truth particle for mj 17 subtraj 0 not found!
10:08:01    RootTrajecto   WARNING   Truth particle with barcode = 73 not found in the input collection!
10:08:01    RootVertexPe   INFO      Total number of reco track-associated truth particles in event : 0
10:08:01    RootVertexPe   INFO      Total number of reco track-associated truth primary vertices : 0

@andiwand
Copy link
Contributor Author

andiwand commented Feb 9, 2023

yeah exactly @pbutti. the particle IDs haven't been persistent until now which confuses all the performance writers

we may also need a particle selector after the simulation because most of the secondary particles will not be reconstructible and will currently ruin all the performance results (as discussed with @paulgessinger yesterday)

@paulgessinger paulgessinger changed the title feat: persist acts barcodes in g4 sim feat: persist ACTS barcodes in G4 sim Feb 9, 2023
@asalzburger
Copy link
Contributor

Hi, looks like this needs an update of the reference for the Geant4 example - not surprising.

@andiwand
Copy link
Contributor Author

andiwand commented Feb 9, 2023

makes sense - should be fixed now

@kodiakhq kodiakhq bot merged commit dafc7b5 into acts-project:main Feb 9, 2023
@github-actions github-actions bot removed the automerge label Feb 9, 2023
@andiwand andiwand deleted the feature-g4sim-barcodes branch February 14, 2023 10:03
kodiakhq bot pushed a commit that referenced this pull request Feb 14, 2023
as discovered in #1842 we should filter particles before and after simulation especially with geant4 as we get a lot of secondaries
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants