Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FPE in RootTrajectorySummaryWriter #1853

Merged

Conversation

andiwand
Copy link
Contributor

in case we cannot find the truth particle we try to cast NaN to int which will cause an FPE

@andiwand andiwand added the Component - Examples Affects the Examples module label Feb 10, 2023
@andiwand andiwand added this to the next milestone Feb 10, 2023
@github-actions
Copy link

github-actions bot commented Feb 10, 2023

📊 Physics performance monitoring for bccc401

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1853 (278d681) into main (7de73eb) will not change coverage.
The diff coverage is n/a.

❗ Current head 278d681 differs from pull request most recent head bccc401. Consider uploading reports for the commit bccc401 to get more accurate results

@@           Coverage Diff           @@
##             main    #1853   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         407      407           
  Lines       22646    22646           
  Branches    10334    10334           
=======================================
  Hits        11210    11210           
  Misses       4247     4247           
  Partials     7189     7189           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit ff31ee5 into acts-project:main Feb 13, 2023
@andiwand andiwand deleted the fix-root-trajectory-summary-writer-fpe branch February 14, 2023 10:01
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants