-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add track to trajectory converter #1857
feat: Add track to trajectory converter #1857
Conversation
This requires writing the tracks to the white board so the track state container stays alive after the algorithm ends.
Simple PR to fix a compilation error against ONNX runtime 1.13.1. Basically, the `Ort::Session::Get{Input,Output}Name` functions got removed starting from 1.13, and we have the use the `Ort::Session::Get{Input,Output}NameAllocated` versions which were introduced in 1.12. One implication is that this PR introduces a lower bound of 1.12.0 on the ONNX runtime version.
097698d
to
a7c3f73
Compare
Codecov Report
@@ Coverage Diff @@
## main #1857 +/- ##
=======================================
Coverage 49.50% 49.50%
=======================================
Files 407 407
Lines 22646 22646
Branches 10334 10334
=======================================
Hits 11210 11210
Misses 4247 4247
Partials 7189 7189 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 0f18b20Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
this is temporary right? so I guess we can forget about doc
Examples/Algorithms/Utilities/include/ActsExamples/Utilities/TracksToTrajectories.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
I suppose so @andiwand, but we also don't have a strong documentation policy for the examples components, as far as I know. |
Add a dedicated conversion algorithm from tracks to trajectories.
Blocked by: