-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: periodic difference for Phi in RootSummaryWriter #1863
fix: periodic difference for Phi in RootSummaryWriter #1863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool 👍 lets get this in
Codecov Report
@@ Coverage Diff @@
## main #1863 +/- ##
=======================================
Coverage 49.50% 49.50%
=======================================
Files 407 407
Lines 22646 22646
Branches 10334 10334
=======================================
Hits 11210 11210
Misses 4247 4247
Partials 7189 7189 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 6d65aadFull report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
The residual computation in the
RootTrajectorySummaryWriter
did not account for the fact that phi is a cyclic variable. This should fix this.