Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: periodic difference for Phi in RootSummaryWriter #1863

Merged

Conversation

benjaminhuth
Copy link
Member

The residual computation in the RootTrajectorySummaryWriter did not account for the fact that phi is a cyclic variable. This should fix this.

@benjaminhuth benjaminhuth added Bug Something isn't working Component - Examples Affects the Examples module labels Feb 14, 2023
@benjaminhuth benjaminhuth added this to the next milestone Feb 14, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool 👍 lets get this in

@andiwand andiwand self-assigned this Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #1863 (3d16c84) into main (5f2cad4) will not change coverage.
The diff coverage is n/a.

❗ Current head 3d16c84 differs from pull request most recent head 6d65aad. Consider uploading reports for the commit 6d65aad to get more accurate results

@@           Coverage Diff           @@
##             main    #1863   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         407      407           
  Lines       22646    22646           
  Branches    10334    10334           
=======================================
  Hits        11210    11210           
  Misses       4247     4247           
  Partials     7189     7189           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Feb 14, 2023

📊 Physics performance monitoring for 6d65aad

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit ae51d11 into acts-project:main Feb 14, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
@benjaminhuth benjaminhuth deleted the fix/periodic-diff-summary-writer branch February 22, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants