Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improved const-correctness for TrackContainer in Examples #1871

Merged

Conversation

paulgessinger
Copy link
Member

Also includes a fix of a missing method in the ConstVectorTrackContainer class.

@paulgessinger paulgessinger added this to the next milestone Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1871 (9ae2c87) into main (910ec13) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1871   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         407      407           
  Lines       22646    22646           
  Branches    10334    10334           
=======================================
  Hits        11210    11210           
  Misses       4247     4247           
  Partials     7189     7189           
Impacted Files Coverage Δ
...re/include/Acts/EventData/VectorTrackContainer.hpp 64.70% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Feb 16, 2023

📊 Physics performance monitoring for 9ae2c87

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - just left one unrelated question

@andiwand andiwand self-assigned this Feb 17, 2023
@andiwand andiwand added Component - Core Affects the Core module automerge labels Feb 17, 2023
@kodiakhq kodiakhq bot merged commit eff1a08 into acts-project:main Feb 17, 2023
@paulgessinger paulgessinger deleted the refactor/example-const-trk-container branch February 17, 2023 09:13
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants