Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Move G4 test preparation to subprocess / fix subprocess invokation #1872

Merged
merged 4 commits into from
Feb 17, 2023
Merged

test: Move G4 test preparation to subprocess / fix subprocess invokation #1872

merged 4 commits into from
Feb 17, 2023

Conversation

paulgessinger
Copy link
Member

No description provided.

@paulgessinger paulgessinger added this to the next milestone Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023 •
edited

Codecov Report

Merging #1872 (2d9a816) into main (bcc917d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1872   +/-   ##
=======================================
  Coverage   49.45%   49.45%           
=======================================
  Files         408      408           
  Lines       22692    22692           
  Branches    10365    10365           
=======================================
  Hits        11222    11222           
  Misses       4264     4264           
  Partials     7206     7206

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Feb 16, 2023 •
edited

📊 Physics performance monitoring for 2d9a816

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand andiwand self-requested a review February 17, 2023 08:05
@andiwand andiwand added the Component - Examples Affects the Examples module label Feb 17, 2023
@paulgessinger paulgessinger mentioned this pull request Feb 17, 2023
Merged
andiwand
andiwand approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andiwand andiwand self-assigned this Feb 17, 2023
@kodiakhq kodiakhq bot merged commit 1e83152 into acts-project:main Feb 17, 2023
@paulgessinger paulgessinger deleted the test/python-improvements branch February 17, 2023 12:58
kodiakhq bot pushed a commit that referenced this pull request Feb 20, 2023
@paulgessinger
refactor: TrackSelector operates on TrackContainer (#1874)
24b4c7a 
Also adds a separate `TrackParameterSelector` which retains the functionality to select from track parameters. `TrackSelector` only operates on `TrackContainer`. There's no mechanism to select `Trajectory` objects anymore.

Blocked by:
- #1872 
- #1870
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees

@andiwand andiwand

Labels
Component - Examples Affects the Examples module
Projects
None yet
Milestone
v23.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulgessinger @andiwand