Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable geantino particle generation #1888

Merged
merged 9 commits into from
Feb 23, 2023

Conversation

andiwand
Copy link
Contributor

Allows shooting geantino particles into the detector with our particle gun

Example gun:

addParticleGun(
    s,
    ParticleConfig(1, acts.PdgParticle.eInvalid, randomizeCharge=False, charge=1, mass=0),
    rnd=rnd,
)

@andiwand andiwand added the Component - Examples Affects the Examples module label Feb 22, 2023
@andiwand andiwand added this to the next milestone Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #1888 (8299f1f) into main (fffb998) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1888   +/-   ##
=======================================
  Coverage   49.44%   49.44%           
=======================================
  Files         408      408           
  Lines       22704    22704           
  Branches    10371    10371           
=======================================
  Hits        11226    11226           
  Misses       4266     4266           
  Partials     7212     7212           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

📊 Physics performance monitoring for 8299f1f

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand
Copy link
Contributor Author

in principle we could drop this completely now

    /// Force pdgCode & mass & charge in G4 units (this is needed for Geantino
    /// simulation)
    std::optional<G4int> forcedPdgCode;
    std::optional<G4double> forcedCharge;  // e.g. 1 for charged geantino
    std::optional<G4double> forcedMass;    // e.g. 0 for geantino

but we still depend on it in https://github.com/acts-project/acts/blob/main/Examples/Run/Geant4/Common/src/Geant4Common.cpp#L77

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in!

@kodiakhq kodiakhq bot merged commit 386611f into acts-project:main Feb 23, 2023
@andiwand andiwand deleted the feature-geantino-particle-gen branch February 23, 2023 23:09
@paulgessinger paulgessinger modified the milestones: next, v23.5.0 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants