Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove missed components as early as possible & more #1921

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Mar 6, 2023

This refactors the Acts::MultiEigenStepperLoop code in a way, that missed components are removed as early as possible. Now the code should also be more consistent, so that some checks and workarounds in the Acts::GsfActor could be removed.

@benjaminhuth benjaminhuth added this to the next milestone Mar 6, 2023
@benjaminhuth benjaminhuth added Component - Core Affects the Core module Improvement Changes to an existing feature labels Mar 6, 2023
@benjaminhuth benjaminhuth changed the title refactor: Remove missed components as early as possible & other stuff refactor: Remove missed components as early as possible & more Mar 6, 2023
@benjaminhuth benjaminhuth added the 🚧 WIP Work-in-progress label Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #1921 (74c5207) into main (9bc6abf) will increase coverage by 0.04%.
The diff coverage is 40.86%.

@@            Coverage Diff             @@
##             main    #1921      +/-   ##
==========================================
+ Coverage   49.48%   49.53%   +0.04%     
==========================================
  Files         408      408              
  Lines       22704    22707       +3     
  Branches    10363    10362       -1     
==========================================
+ Hits        11236    11247      +11     
+ Misses       4257     4251       -6     
+ Partials     7211     7209       -2     
Impacted Files Coverage Δ
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 43.11% <33.33%> (+0.06%) ⬆️
Core/include/Acts/TrackFitting/detail/GsfUtils.hpp 52.30% <33.33%> (+0.79%) ⬆️
.../include/Acts/Propagator/MultiEigenStepperLoop.ipp 36.22% <45.00%> (+4.76%) ⬆️
...e/include/Acts/Propagator/MultiStepperAborters.hpp 65.51% <66.66%> (+0.13%) ⬆️
.../include/Acts/Propagator/MultiEigenStepperLoop.hpp 72.06% <70.00%> (-0.13%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

📊 Physics performance monitoring for 74c5207

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@benjaminhuth benjaminhuth marked this pull request as draft March 6, 2023 20:16
@benjaminhuth benjaminhuth removed the 🚧 WIP Work-in-progress label Mar 7, 2023
@benjaminhuth benjaminhuth marked this pull request as ready for review March 7, 2023 07:23
@kodiakhq kodiakhq bot merged commit 1b4f314 into acts-project:main Mar 7, 2023
@github-actions github-actions bot removed the automerge label Mar 7, 2023
@benjaminhuth benjaminhuth deleted the refactor/multi-stepper-remove-missed-components branch March 7, 2023 09:41
@paulgessinger paulgessinger modified the milestones: next, v23.5.0 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants