Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Seeding constness improvements #1923

Merged
merged 7 commits into from
Mar 9, 2023

Conversation

CarloVarni
Copy link
Collaborator

Trying to move to const in the seeding... this is the first step but cannot yet go further than this

@CarloVarni CarloVarni added this to the next milestone Mar 7, 2023
@CarloVarni CarloVarni added the Component - Core Affects the Core module label Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #1923 (181f6a9) into main (c43b62e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1923   +/-   ##
=======================================
  Coverage   49.53%   49.53%           
=======================================
  Files         408      408           
  Lines       22705    22705           
  Branches    10362    10362           
=======================================
  Hits        11247    11247           
  Misses       4249     4249           
  Partials     7209     7209           
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SeedFilter.hpp 0.00% <ø> (ø)
Core/include/Acts/Seeding/SeedFilter.ipp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedFinder.ipp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedFinderUtils.ipp 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CarloVarni CarloVarni changed the title feat: Adding come const feat: Adding some constness Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

📊 Physics performance monitoring for 181f6a9

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@paulgessinger paulgessinger changed the title feat: Adding some constness feat: Seeding constness improvements Mar 7, 2023
@kodiakhq kodiakhq bot merged commit 5cf1328 into acts-project:main Mar 9, 2023
@github-actions github-actions bot removed the automerge label Mar 9, 2023
@CarloVarni CarloVarni deleted the ConstInputsInSeeding branch March 9, 2023 09:16
@paulgessinger paulgessinger modified the milestones: next, v23.5.0 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants