refactor: avoid unnecessary calculations in triplet compatibility #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisFelipeCoelho
added
Component - Core
LuisFelipeCoelho
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1929 +/- ##
=======================================
Coverage 49.59% 49.59%
=======================================
Files 410 410
Lines 22700 22697 -3
Branches 10359 10358 -1
=======================================
Hits 11257 11257
+ Misses 4231 4228 -3
Partials 7212 7212
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for c11a65eFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
CarloVarni
reviewed
Mar 15, 2023
CarloVarni
approved these changes
Mar 15, 2023
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Mar 23, 2023
…ts-project#1929) This PR moves the calculation of `iSinTheta2 * options.sigmapT2perRadius` to outside the loop over the top triplet component to avoid recalculating this variable for every iteration. It also avoids the calculation of the seed pT if not necessary. This is not supposed to change the physics performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the calculation of
iSinTheta2 * options.sigmapT2perRadiusto outside the loop over the top triplet component to avoid recalculating this variable for every iteration.It also avoids the calculation of the seed pT if not necessary.
This is not supposed to change the physics performance.