feat: minimum number of compatible top SPs to trigger filterSeeds_2SpFixed #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisFelipeCoelho
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #1930 +/- ##
==========================================
- Coverage 49.60% 49.59% -0.02%
==========================================
Files 410 410
Lines 22693 22700 +7
Branches 10356 10359 +3
==========================================
Hits 11257 11257
- Misses 4224 4231 +7
Partials 7212 7212
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 7d97159Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
CarloVarni
approved these changes
Mar 15, 2023
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Mar 23, 2023
…Fixed (acts-project#1930) This is intended to reduce the number of filter iterations by setting a minimum number of compatible top SP candidates that are necessary to run the seed confirmation. It should not affect the physics performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to reduce the number of filter iterations by setting a minimum number of compatible top SP candidates that are necessary to run the seed confirmation.
It should not affect the physics performance