Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Alignment Contextual example binary smearing options #1944

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

paulgessinger
Copy link
Member

No description provided.

@paulgessinger paulgessinger added this to the next milestone Mar 14, 2023
@paulgessinger paulgessinger marked this pull request as ready for review March 14, 2023 13:01
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1944 (8c0a57f) into main (889267b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1944   +/-   ##
=======================================
  Coverage   49.57%   49.57%           
=======================================
  Files         412      412           
  Lines       23310    23310           
  Branches    10604    10604           
=======================================
  Hits        11555    11555           
  Misses       4318     4318           
  Partials     7437     7437           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 14, 2023

📊 Physics performance monitoring for 8c0a57f

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@hherde
Copy link

hherde commented Mar 15, 2023

@LaraCalic and I at Lund have confirmed that the executable ActsExampleDetectorAlignContextual runs successfully with this hot fix. Thanks, Paul!!

@andiwand andiwand added Component - Examples Affects the Examples module automerge labels Mar 21, 2023
@kodiakhq kodiakhq bot merged commit 9328cf3 into acts-project:main Mar 23, 2023
1 check passed
@paulgessinger paulgessinger modified the milestones: next, v24.0.0 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants