refactor: SP builder uses SourceLinks instead of Measurements #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1953 +/- ##
=======================================
Coverage 49.51% 49.52%
=======================================
Files 411 412 +1
Lines 23340 23321 -19
Branches 10634 10622 -12
=======================================
- Hits 11557 11549 -8
Misses 4332 4332
+ Partials 7451 7440 -11
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 7293052Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
CarloVarni
reviewed
Mar 16, 2023
Tests/UnitTests/Core/SpacePointFormation/SpacePointBuilderTests.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlo Varni <75478407+CarloVarni@users.noreply.github.com>
CarloVarni
approved these changes
Mar 21, 2023
|
@toyamaza you have to manually update the PR... the bot can't do it |
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Mar 23, 2023
…roject#1953) This PR changes the SP builder input from Measurements to SourceLink so that users can avoid unnecessary measurement creation. Some SP builder parameters are moved from the config to the option to allow event/module-dependent parameters.
toyamaza
added a commit
to toyamaza/acts
that referenced
this pull request
Mar 24, 2023
…roject#1953) This PR changes the SP builder input from Measurements to SourceLink so that users can avoid unnecessary measurement creation. Some SP builder parameters are moved from the config to the option to allow event/module-dependent parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the SP builder input from Measurements to SourceLink so that users can avoid unnecessary measurement creation.
Some SP builder parameters are moved from the config to the option to allow event/module-dependent parameters.