Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Store unsigned 64bit integer for projector in MTJ backend #1958

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

paulgessinger
Copy link
Member

Is this breaking?

@paulgessinger paulgessinger added this to the next milestone Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #1958 (c838a7c) into main (d2882c8) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1958      +/-   ##
==========================================
- Coverage   49.60%   49.60%   -0.01%     
==========================================
  Files         410      410              
  Lines       23297    23298       +1     
  Branches    10630    10631       +1     
==========================================
  Hits        11557    11557              
  Misses       4292     4292              
- Partials     7448     7449       +1     
Impacted Files Coverage Δ
Core/include/Acts/EventData/MultiTrajectory.hpp 71.12% <50.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 17, 2023

📊 Physics performance monitoring for c838a7c

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@benjaminhuth
Copy link
Member

benjaminhuth commented Mar 17, 2023

I would argue not, because this looks like an implementation detail to me. Is there a reason why the typedef is not in the detail namespace?

@paulgessinger
Copy link
Member Author

I guess it could be, as the "public public" interface is independent of how it's stored, but the "private public" interface (the one the backends are built against) does require this to be known. I don't know, honestly.

Copy link
Contributor

@tboldagh tboldagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely ok from perspective of other ATLAS backend.
Side comment. I realised that probably calling these backend classes: *Backend would relay help in understanding the code.

@kodiakhq kodiakhq bot merged commit 0b61727 into acts-project:main Mar 20, 2023
1 check passed
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Mar 23, 2023
@paulgessinger paulgessinger modified the milestones: next, v24.0.0 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants