Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MLSolver hashe test and compilation in the CI #1959

Merged
merged 22 commits into from
Mar 22, 2023

Conversation

Corentin-Allaire
Copy link
Contributor

This MR adds the Ml Ambiguity solver to the CI. For now, only hashes tests are available, but once the performance evaluation for the solver has been refactored to use root, we should also add it to the test.

@Corentin-Allaire Corentin-Allaire added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Impact - Minor Nuissance bug and/or affects only a single module labels Mar 17, 2023
@Corentin-Allaire Corentin-Allaire added this to the next milestone Mar 17, 2023
@Corentin-Allaire Corentin-Allaire changed the title fear: MLSolver hashe test and compilation in the CI feat: MLSolver hashe test and compilation in the CI Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #1959 (8fcd984) into main (8efbafb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1959   +/-   ##
=======================================
  Coverage   49.54%   49.54%           
=======================================
  Files         412      412           
  Lines       23309    23309           
  Branches    10610    10610           
=======================================
  Hits        11549    11549           
  Misses       4320     4320           
  Partials     7440     7440           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 17, 2023

📊 Physics performance monitoring for 8fcd984

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

cmake/ActsConfig.cmake.in Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit b4773cf into acts-project:main Mar 22, 2023
1 check passed
@paulgessinger paulgessinger modified the milestones: next, v24.0.0 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants