Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce verbosity of ITK module splitter. #1976

Conversation

goetzgaycken
Copy link
Contributor

Reduce the verbosity of the ITK module splitter from INFO to DEBUG. This addresses part of issue
#1975 i.e. the number of messages is reduced.

@goetzgaycken goetzgaycken force-pushed the fix_main_reduce_verbosity_of_itk_module_splitter branch from d8f5774 to 347031f Compare March 21, 2023 17:28
@github-actions
Copy link

github-actions bot commented Mar 21, 2023

📊 Physics performance monitoring for 826a034

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good 👍

CI complains about formatting. will re-approve afterwards

@goetzgaycken goetzgaycken force-pushed the fix_main_reduce_verbosity_of_itk_module_splitter branch 3 times, most recently from 28fa81e to f39234c Compare March 22, 2023 08:29
@goetzgaycken goetzgaycken force-pushed the fix_main_reduce_verbosity_of_itk_module_splitter branch from f39234c to 238b253 Compare March 22, 2023 08:29
@goetzgaycken
Copy link
Contributor Author

goetzgaycken commented Mar 22, 2023

above changes:

@andiwand andiwand added this to the next milestone Mar 22, 2023
@andiwand andiwand added Impact - Minor Nuissance bug and/or affects only a single module Component - Examples Affects the Examples module automerge labels Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1976 (826a034) into main (06af656) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1976   +/-   ##
=======================================
  Coverage   49.54%   49.54%           
=======================================
  Files         412      412           
  Lines       23309    23309           
  Branches    10610    10610           
=======================================
  Hits        11549    11549           
  Misses       4320     4320           
  Partials     7440     7440           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 73b40f3 into acts-project:main Mar 22, 2023
1 check passed
@paulgessinger paulgessinger modified the milestones: next, v24.0.0 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants