Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Space Point Formation requires functions that accepts const reference to source links #1991

Merged
merged 4 commits into from
Apr 12, 2023
Merged

perf: Space Point Formation requires functions that accepts const reference to source links #1991

merged 4 commits into from
Apr 12, 2023

Conversation

CarloVarni
Copy link
Collaborator

No description provided.

@CarloVarni CarloVarni added this to the next milestone Mar 25, 2023
@CarloVarni CarloVarni added the Component - Core Affects the Core module label Mar 25, 2023
@github-actions
Copy link

github-actions bot commented Mar 25, 2023 •
edited

📊 Physics performance monitoring for 45743c1

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Mar 25, 2023 •
edited

Codecov Report

Merging #1991 (45743c1) into main (98f27de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1991   +/-   ##
=======================================
  Coverage   49.83%   49.83%           
=======================================
  Files         421      421           
  Lines       23900    23900           
  Branches    10844    10844           
=======================================
  Hits        11910    11910           
  Misses       4367     4367           
  Partials     7623     7623
Impacted Files Coverage Δ
...s/SpacePointFormation/SpacePointBuilderOptions.hpp 25.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger
Copy link
Member

Can you make the title a bit more descriptive maybe?

@CarloVarni CarloVarni changed the title perf: pass by const ref perf: Space Point Formation requires functions that accepts const reference to source links Mar 27, 2023
tboldagh
tboldagh approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@tboldagh tboldagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supper trivial change. Even if I am not the designated approver let me click approve too.

@toyamaza
Copy link
Contributor

looks good to me as well. thanks.

@kodiakhq kodiakhq bot merged commit 79fe828 into acts-project:main Apr 12, 2023
37 checks passed
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tboldagh tboldagh tboldagh approved these changes

@toyamaza toyamaza Awaiting requested review from toyamaza

Assignees
No one assigned
Labels
Component - Core Affects the Core module
Projects
None yet
Milestone
v25.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CarloVarni @paulgessinger @toyamaza @tboldagh @asalzburger