refactor: Update edm4hep IO code to use frame model #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podio switched to recommending this model, and the store based model we used before is deprecated.
|
Ok I added CMake checks for the podio and edm4hep version. I need to bump our respective versions in our CI images. |
Codecov Report
@@ Coverage Diff @@
## main #2001 +/- ##
=======================================
Coverage 49.83% 49.83%
=======================================
Files 415 415
Lines 23593 23593
Branches 10681 10681
=======================================
Hits 11758 11758
Misses 4330 4330
Partials 7505 7505 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 1bb5274Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
andiwand
approved these changes
Mar 31, 2023
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
andiwand
approved these changes
Apr 4, 2023
andiwand
added
Component - Examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podio switched to recommending this model, and the store based model we used before is deprecated.