Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: LinCircle constructor and no use of fill function #2006

Merged
merged 6 commits into from
Apr 3, 2023

Conversation

CarloVarni
Copy link
Collaborator

@CarloVarni CarloVarni commented Mar 31, 2023

Defining a constructor makes the fillLineCircle function redundant

@CarloVarni CarloVarni added the Component - Core Affects the Core module label Mar 31, 2023
@CarloVarni CarloVarni added this to the next milestone Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #2006 (73963af) into main (1f7443e) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
+ Coverage   49.80%   49.83%   +0.02%     
==========================================
  Files         413      414       +1     
  Lines       23606    23594      -12     
  Branches    10681    10681              
==========================================
  Hits        11758    11758              
+ Misses       4343     4331      -12     
  Partials     7505     7505              
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SeedFinder.ipp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedFinderUtils.hpp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedFinderUtils.ipp 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 31, 2023

📊 Physics performance monitoring for 73963af

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@LuisFelipeCoelho
Copy link
Member

Do you know if this has any effect on CPU performance?

@kodiakhq kodiakhq bot merged commit f44d3b1 into acts-project:main Apr 3, 2023
37 checks passed
@github-actions github-actions bot removed the automerge label Apr 3, 2023
@CarloVarni CarloVarni deleted the LinCircle branch April 3, 2023 09:57
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants