Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Compile time get compatible doublets #2013

Merged

Conversation

CarloVarni
Copy link
Collaborator

No description provided.

@CarloVarni CarloVarni added the 🚧 WIP Work-in-progress label Apr 3, 2023
@CarloVarni CarloVarni added this to the next milestone Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #2013 (557ccc5) into main (08ef3cc) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 557ccc5 differs from pull request most recent head 9e51d87. Consider uploading reports for the commit 9e51d87 to get more accurate results

@@            Coverage Diff             @@
##             main    #2013      +/-   ##
==========================================
+ Coverage   49.83%   49.85%   +0.01%     
==========================================
  Files         421      421              
  Lines       23899    23892       -7     
  Branches    10842    10841       -1     
==========================================
  Hits        11911    11911              
+ Misses       4367     4360       -7     
  Partials     7621     7621              
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SeedFinder.hpp 0.00% <ø> (ø)
Core/include/Acts/Seeding/SeedFinder.ipp 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

📊 Physics performance monitoring for 9e51d87

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@LuisFelipeCoelho LuisFelipeCoelho self-requested a review April 4, 2023 08:23
Copy link
Member

@LuisFelipeCoelho LuisFelipeCoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can remove sign with the following changes:

Core/include/Acts/Seeding/SeedFinder.ipp Outdated Show resolved Hide resolved
Core/include/Acts/Seeding/SeedFinder.ipp Outdated Show resolved Hide resolved
Core/include/Acts/Seeding/SeedFinder.ipp Outdated Show resolved Hide resolved
Core/include/Acts/Seeding/SeedFinder.ipp Outdated Show resolved Hide resolved
@CarloVarni CarloVarni force-pushed the CompileTimeGetCompatibleDoublets branch from e225844 to f884bff Compare April 13, 2023 23:55
@CarloVarni CarloVarni added Component - Core Affects the Core module and removed 🚧 WIP Work-in-progress labels Apr 14, 2023
@CarloVarni CarloVarni marked this pull request as ready for review April 14, 2023 00:04
@CarloVarni CarloVarni added the Improvement Changes to an existing feature label Apr 14, 2023
@kodiakhq kodiakhq bot merged commit a1b43a8 into acts-project:main Apr 14, 2023
36 checks passed
@CarloVarni CarloVarni deleted the CompileTimeGetCompatibleDoublets branch April 14, 2023 13:54
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
paulgessinger pushed a commit that referenced this pull request Aug 29, 2023
This is my first attempt to implement compile-time
DetectorMeasurementInfo for SSS, as alternative to PR #1985 and
following the same approach by @CarloVarni #2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants