-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: EDM4hep plugin, Track reader + writer #2022
feat: EDM4hep plugin, Track reader + writer #2022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! code looks very clear and clean to me. left two minor comments
Codecov Report
@@ Coverage Diff @@
## main #2022 +/- ##
=======================================
Coverage 49.83% 49.83%
=======================================
Files 421 421
Lines 23900 23900
Branches 10844 10844
=======================================
Hits 11910 11910
Misses 4367 4367
Partials 7623 7623
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
I found some potential further issues locally on macOS. Taking this WIP until fixed. |
📊 Physics performance monitoring for a3293ccFull report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
This PR adds a writer and a reader for
TrackContainer
to and from EDM4hep track objects and track states.This is unfortunately not lossless:
Since I want the conversion functionality to live in Core, I add an EDM4hep plugin here, that the existing EDM4hep IO example now uses. The Example-specific functions are kept where they are, but
TrackContainer
and some helper now live in a Core plugin.I'm also changing over the
MultiTrajectory
writer to use the new covariance and parameters conversion.