-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Restructure the ONNX and mlpack plugins #2025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work ! Maybe we should have ping you directly on the previous PR before merging it...
📊 Physics performance monitoring for 59b322fFull report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
Codecov Report
@@ Coverage Diff @@
## main #2025 +/- ##
=======================================
Coverage 49.83% 49.83%
=======================================
Files 421 421
Lines 23900 23900
Branches 10844 10844
=======================================
Hits 11910 11910
Misses 4367 4367
Partials 7623 7623 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
there is something going wrong with the ExaTrkX test on the CI bridge... undefined symbol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 % clean
Right I think that's one missing branch where I don't add the stub. Hope it's fixed now. |
I think it's fixed now @benjaminhuth |
Fixes the CMake configuration, python bindings, naming conventions, build dependencies etc. Should not change anything about the execution itself.