Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Restructure the ONNX and mlpack plugins #2025

Merged
merged 8 commits into from
Apr 12, 2023

Conversation

paulgessinger
Copy link
Member

Fixes the CMake configuration, python bindings, naming conventions, build dependencies etc. Should not change anything about the execution itself.

@paulgessinger paulgessinger added this to the next milestone Apr 12, 2023
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work ! Maybe we should have ping you directly on the previous PR before merging it...

@github-actions
Copy link

github-actions bot commented Apr 12, 2023

📊 Physics performance monitoring for 59b322f

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #2025 (59b322f) into main (79fe828) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2025   +/-   ##
=======================================
  Coverage   49.83%   49.83%           
=======================================
  Files         421      421           
  Lines       23900    23900           
  Branches    10844    10844           
=======================================
  Hits        11910    11910           
  Misses       4367     4367           
  Partials     7623     7623           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth
Copy link
Member

there is something going wrong with the ExaTrkX test on the CI bridge... undefined symbol Acts::Python::addOnnxMlpack(Acts::Python::Context&).

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 % clean

@paulgessinger
Copy link
Member Author

there is something going wrong with the ExaTrkX test on the CI bridge... undefined symbol Acts::Python::addOnnxMlpack(Acts::Python::Context&).

Right I think that's one missing branch where I don't add the stub. Hope it's fixed now.

@paulgessinger
Copy link
Member Author

I think it's fixed now @benjaminhuth

@kodiakhq kodiakhq bot merged commit 15aec1a into acts-project:main Apr 12, 2023
37 checks passed
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants