refactor: Mockup builder files location #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitra97
force-pushed
the
mockup-builder-files-location
branch
from
0bd9f3f
to
92fc7ee
Compare
Codecov Report
@@ Coverage Diff @@
## main #2029 +/- ##
=======================================
Coverage 49.85% 49.85%
=======================================
Files 421 421
Lines 23889 23889
Branches 10843 10843
=======================================
Hits 11911 11911
Misses 4357 4357
Partials 7621 7621 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dimitra97
force-pushed
the
mockup-builder-files-location
branch
from
92fc7ee
to
5cd841b
Compare
📊 Physics performance monitoring for 696b3d7Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
andiwand
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
cool! looks good from my side
also pinging @noemina and @paulgessinger if they have feedback for the foldering and layout
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
andiwand
approved these changes
Apr 17, 2023
andiwand
reviewed
Apr 17, 2023
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
andiwand
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR locates the files that hold the class for the construction of the muon spectrometer mock up into another folder.